Correct the function type #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Oct 7, 2024
The function pointer type of myvariable_store was incompatible with the store member of struct kobj_attribute, leading to a compilation error when the type conversion (void *) was omitted. This patch corrects the function declaration and eliminates the need for type conversion.
|
Just refine the git commit message. Please review it again, thx! |
|
Thank @NOVBobLee for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function pointer type of myvariable_store is incompatible with the store member of struct kobj_attribute[1]. So, if we omit the type conversion (void *), we will meet a compilation error. This patch corrects the function declaration and removes the type conversion.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/kobject.h#n139